[Debug] Deprecate ContextErrorException #21388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Btw, it would be great to fix the deps=high failures in the VarDumper component |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jan 24, 2017
This PR was merged into the 3.3-dev branch. Discussion ---------- [Debug] Deprecate ContextErrorException | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Since the `$context` argument is going to be deprecated in PHP 7.2 (see https://wiki.php.net/rfc/deprecations_php_7_2#errcontext_argument_of_error_handler), let's deprecate ContextErrorException altogether. Commits ------- c379707 [Debug] Deprecate ContextErrorException
Merged
Tobion
reviewed
May 26, 2017
| @@ -71,13 +70,12 @@ public function testNotice() | |||
|
|
|||
| try { | |||
| self::triggerNotice($this); | |||
There was a problem hiding this comment.
The variable and comment in triggerNotice should be removed
There was a problem hiding this comment.
removed in 0bcc5af
nicolas-grekas
added a commit
that referenced
this pull request
Jul 6, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [Debug] Removed ContextErrorException | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21388 | License | MIT | Doc PR | n/a Commits ------- 76dc317 Removed ContextErrorException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
$contextargument is going to be deprecated in PHP 7.2 (see https://wiki.php.net/rfc/deprecations_php_7_2#errcontext_argument_of_error_handler), let's deprecate ContextErrorException altogether.