Remove some class parameters related to Routing #21739
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lepiaf
commented
Feb 23, 2017
•
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #21735 |
| License | MIT |
| Doc PR | no |
|
I bet there will be users out there who rely on these parameters. At least, we should document this in the upgrade file. |
|
I'm totally in favor of removing this. But are you sure you want to do that BC break in 3.x? |
|
Let's keep that one for 4.0. @lepiaf Can you create a new PR on master (aka 3.3) with just a note in the UPGRADE/CHANGELOG file that those parameters are deprecated and will be removed in 4.0? |
|
Should I create CHANGELOG-4.0.md file ? It does not exists yet. |
|
@lepiaf The global changelog files are generated automatically. You can just add a new entry to the changelog file of the Routing component. |
fabpot
added a commit
that referenced
this pull request
Mar 4, 2017
This PR was merged into the 3.3-dev branch. Discussion ---------- Add deprecation note on routing class parameters | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #21735 | License | MIT | Doc PR | no Create PR with note about deprecation of class parameters. #21739 (comment) Commits ------- 5b0641e Add deprecation note on routing class parameters
symfony-splitter
pushed a commit
to symfony/routing
that referenced
this pull request
Mar 4, 2017
This PR was merged into the 3.3-dev branch. Discussion ---------- Add deprecation note on routing class parameters | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | symfony/symfony#21735 | License | MIT | Doc PR | no Create PR with note about deprecation of class parameters. symfony/symfony#21739 (comment) Commits ------- 5b0641ebe1 Add deprecation note on routing class parameters
|
Closing in favor of #21824 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.