Add deprecation note on routing class parameters #21824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also add a note in the Routing component CHANGELOG stating that these parameters are deprecated? And also a note in UPGRADE-3.3.md? Thanks. |
chalasr
reviewed
Mar 1, 2017
UPGRADE-4.0.md
Outdated
| @@ -207,6 +207,16 @@ FrameworkBundle | |||
|
|
|||
| * Extending `ConstraintValidatorFactory` is not supported anymore. | |||
|
|
|||
| * Class parameters in `routing.xml` has been removed | |||
There was a problem hiding this comment.
has => have. Also I think that the place into which parameters were defined does not matter that much for end users. Class parameters related to routing..., Routing class parameters...?
|
is there a way to trigger a deprecation warning (in a late compiler pass maybe) when these parameters are replaced with values different than the default ones ? |
|
@stof I don't remember doing so when we removed such params in 3.0, did we? Not sure it's really worth it. |
|
Thank you @lepiaf. |
fabpot
added a commit
that referenced
this pull request
Mar 4, 2017
This PR was merged into the 3.3-dev branch. Discussion ---------- Add deprecation note on routing class parameters | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #21735 | License | MIT | Doc PR | no Create PR with note about deprecation of class parameters. #21739 (comment) Commits ------- 5b0641e Add deprecation note on routing class parameters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create PR with note about deprecation of class parameters.
#21739 (comment)