[PHPunitBridge] Count @expectedDeprecation as an assertion #21896
Conversation
|
@xabbuh This can be closed then, right? |
|
Yes, except that #21828 is merged as a feature. However, I consider it a bug fix and thus it has to be backported to 3.2. Imo, counting the |
|
Fair enough, but note that you will probably check first that the test is neither skipped nor incomplete (see how #21828 was implemented). |
|
Yeah, I think if it's decided to backport this to 3.2, the #21828 PR should simply be backported (and this PR should just be closed). |
|
Except the trait does not exist in 3.2 IIRC, so this should be done here. |
|
Ah, my bad. Updated the PR to match the code added in 3.3. |
|
Thank you @wouterj. |
… (wouterj) This PR was merged into the 3.2 branch. Discussion ---------- [PHPunitBridge] Count @expectedDeprecation as an assertion | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - By adding `addToAssertionCount()`, the `@expectedDeprecation` annotation is recognized as an assertion by PHPUnit. This means PHPUnit will not report the test as risky because it does not contain any assertion. Commits ------- ba5c0f4 Count @expectedDeprecation as an assertion
By adding
addToAssertionCount(), the@expectedDeprecationannotation is recognized as an assertion by PHPUnit. This means PHPUnit will not report the test as risky because it does not contain any assertion.