[Form] Choice type int values (BC Fix) #21957
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
480d18c to
4953631
Compare
4953631 to
be1c3a8
Compare
stof
reviewed
Mar 10, 2017
| @@ -171,7 +171,7 @@ public function buildForm(FormBuilderInterface $builder, array $options) | |||
| } | |||
|
|
|||
| foreach ($data as $v) { | |||
| if (null !== $v && !is_string($v)) { | |||
| if (null !== $v && !is_string($v) && !is_int($v)) { | |||
| throw new TransformationFailedException('All choices submitted must be NULL or strings.'); | |||
be1c3a8 to
56e3974
Compare
56e3974 to
dad87f8
Compare
|
Thank you @mcfedr. |
fabpot
added a commit
that referenced
this pull request
Mar 10, 2017
This PR was squashed before being merged into the 2.7 branch (closes #21957). Discussion ---------- [Form] Choice type int values (BC Fix) | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21952 | License | MIT #21267 unnecessarily forced all choice values to be strings, this was a BC braking change. Everything can work fine if they are strings or ints. specifically the issue was because `array_flip` is used on the `choices` array, but this function will work fine with ints as well as strings. Normally, when using HTML forms all data comes as strings, but the `symfony/form` component has use cases beyond this, specifically, I use it with JSON data, where valid values for a `ChoiceType` might not be strings. Commits ------- ed211e9 [Form] Choice type int values (BC Fix)
|
Thank you @fabpot for Symfony :) |
|
This needs to land it 2.8 and 3.2 branches as well. |
|
Merged into 2.8 as well. For 3.2, I will let @nicolas-grekas do the merge |
chihiro-adachi
pushed a commit
to chihiro-adachi/ec-cube
that referenced
this pull request
Mar 14, 2017
- symfony 3.2.5/6で、choice typeでint値を受け付けなくなっていたため(symfony/symfony#21267) - 21267はbc break扱いで再度修正が入っている(symfony/symfony#21957) - symfony3.2.7で解消されると思われるが、テスト通したいので直しておく
|
Ping @nicolas-grekas - any ETA on the 3.2 merge? We're still locked to 3.2.4 here as a result of the issue. 😢 |
|
@superhaggis It's been merged a while ago. |
|
Or are you asking for a new release? In that case, that should be done very soon. |
|
@fabpot Yeah, I guess I'm asking for a new release. Thanks for the update. 😄 |
Merged
|
When will this fix be released in 3.2.*? Downgrading right now to 3.2.4 :( |
|
A new 3.2 version will probably be released today. |
Merged
chihiro-adachi
pushed a commit
to chihiro-adachi/ec-cube
that referenced
this pull request
Apr 5, 2017
…y/symfony#21267) - 21267はbc break扱いで再度修正が入っている(symfony/symfony#21957) - symfony3.2.7で解消されると思われるが、テスト通したいので直しておく
Merged
fabpot
added a commit
that referenced
this pull request
May 9, 2017
This PR was merged into the 2.7 branch. Discussion ---------- [Form] Minor: Fix comment in ChoiceType | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | n/a | Fixed tickets | n/a | License | MIT | Doc PR | n/a Forgotten to be updated in: #21957 Commits ------- a49d79c [Form] Minor: Fix comment in ChoiceType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21267 unnecessarily forced all choice values to be strings, this was a BC braking change.
Everything can work fine if they are strings or ints. specifically the issue was because
array_flipis used on thechoicesarray, but this function will work fine with ints as well as strings.Normally, when using HTML forms all data comes as strings, but the
symfony/formcomponent has use cases beyond this, specifically, I use it with JSON data, where valid values for aChoiceTypemight not be strings.