Skip to content

[FrameworkBundle] remove translator helper if Translator is disabled #22006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2017
Merged

[FrameworkBundle] remove translator helper if Translator is disabled #22006

merged 1 commit into from
Mar 17, 2017

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 15, 2017 •
edited
Loading

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #20928 (comment), #21374
License MIT
Doc PR

This was referenced Mar 15, 2017
Merged
Closed
@xabbuh xabbuh added this to the 3.3 milestone Mar 15, 2017
nicolas-grekas
nicolas-grekas approved these changes Mar 17, 2017
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fabpot
Copy link
Member

fabpot commented Mar 17, 2017

Thank you @xabbuh.

@fabpot fabpot merged commit 25ea510 into symfony:master Mar 17, 2017
fabpot added a commit that referenced this pull request Mar 17, 2017
@fabpot
bug #22006 [FrameworkBundle] remove translator helper if Translator i…
6446639 
…s disabled (xabbuh)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[FrameworkBundle] remove translator helper if Translator is disabled

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20928 (comment), #21374
| License       | MIT
| Doc PR        |

Commits
-------

25ea510 remove translator helper if Translator is disabled
@xabbuh xabbuh deleted the pr-20928 branch March 17, 2017 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @fabpot @nicolas-grekas @carsonbot