Skip to content

[Yaml] Support tagged scalars #22762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2017
Merged

[Yaml] Support tagged scalars #22762

merged 1 commit into from
Jul 6, 2017

Conversation

GuilhemN
Copy link
Contributor

@GuilhemN GuilhemN commented May 18, 2017

Q A
Branch? master
Bug fix? no
New feature? yes, replacement of deprecations
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Add support of tagged scalars in 4.0.

@nicolas-grekas
Copy link
Member

missing CHANGELOG updates in components (please check any your other PRs also if any)

@GuilhemN
Copy link
Contributor Author

@nicolas-grekas note added

@xabbuh
Copy link
Member

xabbuh commented May 25, 2017

@GuilhemN Can you rebase here now that #22770 is merged?

@GuilhemN GuilhemN force-pushed the YAMLTAG branch 3 times, most recently from aeb8050 to 1dea536 Compare May 25, 2017 09:15
@GuilhemN
Copy link
Contributor Author

done

@@ -21,6 +21,12 @@ CHANGELOG
the parser and dumper is no longer supported, pass bitmask flags instead
* the constructor arguments of the `Parser` class have been removed
* the `Inline` class is internal and no longer part of the BC promise
* added support of tagged scalars.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

support for

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, thanks

fabpot added a commit that referenced this pull request Jun 14, 2017
This PR was merged into the 3.4 branch.

Discussion
----------

[Yaml] Deprecate using the non-specific tag

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Values tagged with the non-specific tag must not be transformed in an integer, this tag means that they must not be evaluated (see [the spec](http://www.yaml.org/spec/1.2/spec.html#tag/non-specific/)).

I applied this change in #22762 to comply with the spec.

Commits
-------

60f5046 [Yaml] Deprecate using the non-specific tag
symfony-splitter pushed a commit to symfony/yaml that referenced this pull request Jun 14, 2017
This PR was merged into the 3.4 branch.

Discussion
----------

[Yaml] Deprecate using the non-specific tag

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Values tagged with the non-specific tag must not be transformed in an integer, this tag means that they must not be evaluated (see [the spec](http://www.yaml.org/spec/1.2/spec.html#tag/non-specific/)).

I applied this change in symfony/symfony#22762 to comply with the spec.

Commits
-------

60f5046661 [Yaml] Deprecate using the non-specific tag
@fabpot
Copy link
Member

fabpot commented Jul 6, 2017

Thank you @GuilhemN.

@fabpot fabpot merged commit b1e8ebc into symfony:master Jul 6, 2017
fabpot added a commit that referenced this pull request Jul 6, 2017
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Yaml] Support tagged scalars

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes, replacement of deprecations
| BC breaks?    | yes
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Add support of tagged scalars in 4.0.

Commits
-------

b1e8ebc [Yaml] Support tagged scalars
@GuilhemN GuilhemN deleted the YAMLTAG branch July 6, 2017 10:31
@fabpot fabpot mentioned this pull request Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants