[Yaml] remove legacy php/const and php/object tag support #23790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Aug 4, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
xabbuh
commented
Aug 4, 2017
| @@ -690,7 +651,7 @@ private static function parseTag($value, &$i, $flags) | |||
| $nextOffset += strspn($value, ' ', $nextOffset); | |||
|
|
|||
| // Is followed by a scalar and is a built-in tag | |||
| if ($tag && (!isset($value[$nextOffset]) || !in_array($value[$nextOffset], array('[', '{'), true)) && ('!' === $tag[0] || 'str' === $tag || 0 === strpos($tag, 'php/const:') || 0 === strpos($tag, 'php/object:'))) { | |||
| if ($tag && (!isset($value[$nextOffset]) || !in_array($value[$nextOffset], array('[', '{'), true)) && ('!' === $tag[0] || 'str' === $tag || 'php/const' === $tag || 'php/object' === $tag)) { | |||
There was a problem hiding this comment.
This is the part that is needed to make the tests green again.
javiereguiluz
approved these changes
Aug 4, 2017
chalasr
approved these changes
Aug 5, 2017
GuilhemN
approved these changes
Aug 5, 2017
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 5, 2017
…ort (xabbuh) This PR was merged into the 4.0-dev branch. Discussion ---------- [Yaml] remove legacy php/const and php/object tag support | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 7f6a0d8 remove legacy php/const and php/object tag support
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.