[ProxyManagerBridge] remove deprecated features #22785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
May 19, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
c60ab5d to
9b4c44b
Compare
|
#22818 must be merged first to make tests pass |
| @@ -17,7 +17,7 @@ | |||
| ], | |||
| "require": { | |||
| "php": "^7.1.3", | |||
| "symfony/dependency-injection": "~3.4|~4.0", | |||
| "symfony/dependency-injection": "~4.0", | |||
There was a problem hiding this comment.
can't we try harder to not add this? is there a way to do so?
There was a problem hiding this comment.
In fact, we do not need to change anything here. Fixed.
780747d to
e2335e8
Compare
nicolas-grekas
added a commit
that referenced
this pull request
May 24, 2017
…0 (xabbuh) This PR was submitted for the 3.4 branch but it was merged into the 3.3 branch instead (closes #22818). Discussion ---------- [DependencyInjection] prepare for signature change in 4.0 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | see failing tests in #22785 Commits ------- c4b6e20 [DI] prepare for signature change in 4.0
|
rebase unlocked |
e2335e8 to
3a12949
Compare
|
rebased |
Simperfit
approved these changes
May 24, 2017
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
May 24, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [ProxyManagerBridge] remove deprecated features | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 3a12949 [ProxyManagerBridge] remove deprecated features
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.