Skip to content

[DependencyInjection] prepare for signature change in 4.0 #22818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented May 21, 2017

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

see failing tests in #22785

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xabbuh xabbuh force-pushed the proxy-manager-bridge-forward-compatibility branch from 4753861 to 0112e29 Compare May 24, 2017 11:26
@xabbuh xabbuh force-pushed the proxy-manager-bridge-forward-compatibility branch from 0112e29 to 571db67 Compare May 24, 2017 11:28
@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

nicolas-grekas added a commit that referenced this pull request May 24, 2017
…0 (xabbuh)

This PR was submitted for the 3.4 branch but it was merged into the 3.3 branch instead (closes #22818).

Discussion
----------

[DependencyInjection] prepare for signature change in 4.0

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

see failing tests in #22785

Commits
-------

c4b6e20 [DI] prepare for signature change in 4.0
@xabbuh xabbuh deleted the proxy-manager-bridge-forward-compatibility branch May 24, 2017 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants