[FrameworkBundle] Remove deprecated code #22800
Conversation
| @@ -33,10 +30,6 @@ protected function configure() | |||
| { | |||
| $this | |||
| ->setName('cache:clear') | |||
| ->setDefinition(array( | |||
| new InputOption('no-warmup', '', InputOption::VALUE_NONE, 'Do not warm up the cache'), | |||
There was a problem hiding this comment.
What is actually the strategy regarding this option? Removing it entirely is a BC break and it was part of the upgrade path.
Should we just keep it as noop and deprecate it to be removed in 5.0?
There was a problem hiding this comment.
A similar option in a form was used as a bc layer between 2.8->3.0, it was kept in 3.0 and deprecated in 3.1 only.
So I would just ignore it and deprecate it in 4.1.
There was a problem hiding this comment.
Thanks for the heads up. I'll revert this line then :)
|
I've got a question regarding the So, should we remove it? ping @GuilhemN |
I didn't need to deprecate it in #21730 so I didn't do it. I also thought it might be useful for those who want to use an existing container, but as we're moving more and more to fqcn services maybe it's better to remove it indeed, this does require a bc layer in 3.3 or 3.4 though. |
|
I'll submit a PR to suggest deprecating it in 3.4 then. Thank you! |
| protected $container; | ||
| protected $validators; | ||
| private $container; | ||
| private $validators; |
There was a problem hiding this comment.
do we have a notice somewhere about that in a 3.x version?
There was a problem hiding this comment.
The class is marked as @final since 3.3, which should trigger the notice. The upgrade files and changelogs also mention those properties will be removed.
|
See #22808 about the deprecation of |
|
rebase needed |
|
Rebased. |
| * Removed core form types services registration when unnecessary | ||
| * Removed `framework.serializer.cache` option and `serializer.mapping.cache.apc`, `serializer.mapping.cache.doctrine.apc` services | ||
| * Removed `ConstraintValidatorFactory::$validators` and `ConstraintValidatorFactory::$container` protected properties | ||
| * Removed class parameters related to routing |
There was a problem hiding this comment.
any reference saying this is what we planned to do?
There was a problem hiding this comment.
Sure, it's mentioned in https://github.com/symfony/symfony/blob/master/UPGRADE-3.3.md#frameworkbundle:
Class parameters related to routing have been deprecated and will be removed in 4.0.
ref: #21824
|
👍 |
…or instances/aliases over using the service locator (ogizanagi) This PR was merged into the 3.3 branch. Discussion ---------- [FrameworkBundle][Validator] Deprecate passing validator instances/aliases over using the service locator | Q | A | ------------- | --- | Branch? | 3.3 <!-- see comment below --> | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | yes <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #22800 (comment) <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Commits ------- df747ce [FrameworkBundle][Validator] Deprecate passing validator instances/aliases over using the service locator
…or instances/aliases over using the service locator (ogizanagi) This PR was merged into the 3.3 branch. Discussion ---------- [FrameworkBundle][Validator] Deprecate passing validator instances/aliases over using the service locator | Q | A | ------------- | --- | Branch? | 3.3 <!-- see comment below --> | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | yes <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | symfony/symfony#22800 (comment) <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Commits ------- df747ce [FrameworkBundle][Validator] Deprecate passing validator instances/aliases over using the service locator
|
Thank you @ogizanagi. |
This PR was merged into the 4.0-dev branch. Discussion ---------- [FrameworkBundle] Remove deprecated code | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | yes | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Remove deprecated code in the FrameworkBundle (except compiler passes and stuff already removed by #22749): * Removed `cache:clear` warmup part along with the `--no-optional-warmers` option. * Removed core form types services registration when unnecessary * Removed `framework.serializer.cache` option and `serializer.mapping.cache.apc`, `serializer.mapping.cache.doctrine.apc` services * Removed `ConstraintValidatorFactory::$validators` and `ConstraintValidatorFactory::$container` protected properties * Removed class parameters related to routing * Removed absolute template paths support in the template name parser Commits ------- 531156e [FrameworkBundle] Remove deprecated code
Remove deprecated code in the FrameworkBundle (except compiler passes and stuff already removed by #22749):
cache:clearwarmup part along with the--no-optional-warmersoption.framework.serializer.cacheoption andserializer.mapping.cache.apc,serializer.mapping.cache.doctrine.apcservicesConstraintValidatorFactory::$validatorsandConstraintValidatorFactory::$containerprotected properties