[DI] Deprecate Container::initialized() for privates #22803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -403,7 +407,7 @@ public function getServiceIds() | |||
| } | |||
| $ids[] = 'service_container'; | |||
|
|
|||
| return array_unique(array_merge($ids, array_keys($this->methodMap), array_keys($this->services))); | |||
| return array_values(array_unique(array_merge($ids, array_keys($this->methodMap), array_keys($this->services)))); | |||
There was a problem hiding this comment.
what is this for? related?
There was a problem hiding this comment.
i noted with https://github.com/symfony/symfony/pull/22801/files#diff-8aeba2b88d0347062017ee160a6beb49R141 keys are preserved; i want to do a clean assertion against getServiceIds, not relying on array_values or indexes in tests.
But can be left out yes; i just used this PR to make the change as of 3.4 :)
Do you want a separate PR or rely on the current behavior?
There was a problem hiding this comment.
Reverted. not yet an issue in 3.4.
|
Thank you @ro0NL. |
nicolas-grekas
added a commit
that referenced
this pull request
May 22, 2017
…ro0NL) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Deprecate Container::initialized() for privates | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes-ish | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> See #22801 (comment) Failing test seems unrelated. Commits ------- e0eb247 [DI] Deprecate Container::initialized() for privates
nicolas-grekas
added a commit
that referenced
this pull request
Jul 13, 2017
…:initialized (ro0NL) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Check privates before resolving alias in Container::initialized | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no, fixes an existing one | Tests pass? | yes, we dont test this behavior :( | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> Continuation of #22803, so it's consistent with logic in `has()` etc. Commits ------- c4b6066 [DI] Check privates before resolving alias in Container::initialized
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #22801 (comment)
Failing test seems unrelated.