Skip to content

[DI] Check privates before resolving alias in Container::initialized #23492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2017
Merged

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Jul 12, 2017

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no, fixes an existing one
Tests pass? yes, we dont test this behavior :(
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

Continuation of #22803, so it's consistent with logic in has() etc.

@nicolas-grekas
Copy link
Member

Thank you @ro0NL.

@nicolas-grekas nicolas-grekas merged commit c4b6066 into symfony:3.4 Jul 13, 2017
nicolas-grekas added a commit that referenced this pull request Jul 13, 2017
…:initialized (ro0NL)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Check privates before resolving alias in Container::initialized

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no, fixes an existing one
| Tests pass?   | yes, we dont test this behavior :(
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

Continuation of #22803, so it's consistent with logic in `has()` etc.

Commits
-------

c4b6066 [DI] Check privates before resolving alias in Container::initialized
@ro0NL ro0NL deleted the di-patch branch July 13, 2017 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants