[Debug] Removed ContextErrorException #22804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbabker
commented
May 20, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #21388 |
| License | MIT |
| Doc PR | n/a |
| @@ -84,11 +84,6 @@ public function testUnsilencing() | |||
|
|
|||
| public function testStacking() | |||
There was a problem hiding this comment.
This test case doesn't test anything anymore.
In fact, this makes me think we should deprecate ErrorHandler::stackErrors() / ErrorHandler::unstackErrors() in 3.4
they are workaround for bugs that are fixed in 5.5.9
this would make this test case @group legacy thus the removal would be plain legitimate.
would you mind doing so on 3.4 ?
There was a problem hiding this comment.
hum in fact it would require this test case to be remove in 3.4 altogether because DebugClassLoader shouldn't call these methods anymore then. Even better :)
There was a problem hiding this comment.
Let me give this a try and we'll see what happens.
nicolas-grekas
added a commit
that referenced
this pull request
Jul 6, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [Debug] Deprecate support for stacked errors | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #22804 | License | MIT | Doc PR | n/a Per discussion in #22804 this deprecates support for error stacking. // @nicolas-grekas Commits ------- 04b8b80 Deprecate support for stacked errors
|
Should be good to go. |
|
Thank you @mbabker. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 6, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [Debug] Removed ContextErrorException | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21388 | License | MIT | Doc PR | n/a Commits ------- 76dc317 Removed ContextErrorException
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.