[Yaml] Deprecate using the non-specific tag #22909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
May 25, 2017
| @@ -610,6 +610,8 @@ private static function evaluateScalar($scalar, $flags, $references = array()) | |||
| case 0 === strpos($scalar, '!str'): | |||
| return (string) substr($scalar, 5); | |||
| case 0 === strpos($scalar, '! '): | |||
| @trigger_error('Using the non-specific tag "!" is deprecated since version 3.3 as its behavior will change in 4.0. It will force non-evaluating your values in 4.0. Use plain integers or !!float instead.', E_USER_DEPRECATED); | |||
xabbuh
reviewed
May 25, 2017
| @@ -928,6 +928,7 @@ documents: 2 | |||
|
|
|||
| --- | |||
| test: Explicit typing | |||
| deprecated: Using the non-specific tag "!" is deprecated since version 3.3 as its behavior will change in 4.0. | |||
fabpot
approved these changes
Jun 14, 2017
|
Thank you @GuilhemN. |
fabpot
added a commit
that referenced
this pull request
Jun 14, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [Yaml] Deprecate using the non-specific tag | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Values tagged with the non-specific tag must not be transformed in an integer, this tag means that they must not be evaluated (see [the spec](http://www.yaml.org/spec/1.2/spec.html#tag/non-specific/)). I applied this change in #22762 to comply with the spec. Commits ------- 60f5046 [Yaml] Deprecate using the non-specific tag
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Values tagged with the non-specific tag must not be transformed in an integer, this tag means that they must not be evaluated (see the spec).
I applied this change in #22762 to comply with the spec.