Skip to content

[SecurityBundle] Add user impersonation info and exit action to the profiler #23026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[SecurityBundle] Add user impersonation info and exit action to the profiler #23026

wants to merge 3 commits into from

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Jun 2, 2017 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #23094
License MIT

Toolbar item result:

toolbar

I'm no sure if more information should be displayed from source token, wdyt?

Security profile panel result:

security_token_profile_panel

@yceruto
Copy link
Member Author

yceruto commented Jun 2, 2017

AppVeyor fails unrelated

@nicolas-grekas
Copy link
Member

Should be for 3.4

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jun 2, 2017
@yceruto
Copy link
Member Author

yceruto commented Jun 2, 2017

Comments addressed and I've updated the screenshot with "Impersonator" label, thanks!

@ogizanagi
Copy link
Contributor

You forgot to change the targeted branch for 3.4 😉

@yceruto yceruto changed the title [WebProfilerBundle] Add user impersonation info and exit action [SecurityBundle] Add user impersonation info and exit action to the profiler Jun 2, 2017
@yceruto yceruto changed the base branch from master to 3.4 June 2, 2017 12:22
@yceruto yceruto changed the base branch from 3.4 to master June 2, 2017 12:24
@yceruto yceruto changed the base branch from master to 3.4 June 2, 2017 12:40
@yceruto yceruto changed the base branch from 3.4 to master June 2, 2017 12:44
@yceruto yceruto changed the base branch from master to 3.4 June 2, 2017 14:13
@yceruto
Copy link
Member Author

yceruto commented Jun 2, 2017 •
edited
Loading

Sorry for the (base branch) mess :) I was not on the PC and I needed to resolve a conflict.

Rebased!

@yceruto yceruto force-pushed the impersonation branch 2 times, most recently from b93a942 to 5053a9b Compare June 5, 2017 17:22
@yceruto yceruto mentioned this pull request Jun 7, 2017
Closed
@yceruto
Copy link
Member Author

yceruto commented Jun 21, 2017 •
edited
Loading

The failure occurs in deps=high because the new const does not exists in Security master yet.

I've finished here, ready for final review!

fabpot
fabpot requested changes Jun 21, 2017
View reviewed changes
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deps in composer.json should be updated as well as the bundle requires the constant to be available.

@yceruto
Copy link
Member Author

yceruto commented Jun 21, 2017 •
edited
Loading

@fabpot the composer.json of the bundle was already updated in other PR to the top available ~3.4 (Btw same case of failure (see comment)) and the constant was introduced here also, so I don't understand what I should do to avoid the failure on deps=high which loads dev-master (~4.0) of the Security Component?

I guess this failure will be solved when this commit is merged into master branch?

@fabpot
Copy link
Member

fabpot commented Jun 21, 2017

Thank you @yceruto.

fabpot added a commit that referenced this pull request Jun 21, 2017
@fabpot
feature #23026 [SecurityBundle] Add user impersonation info and exit …
2c438c5 
…action to the profiler (yceruto)

This PR was squashed before being merged into the 3.4 branch (closes #23026).

Discussion
----------

[SecurityBundle] Add user impersonation info and exit action to the profiler

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23094
| License       | MIT

Toolbar item result:

![toolbar](https://cloud.githubusercontent.com/assets/2028198/26724555/1b60320a-4768-11e7-8433-da935f7068e9.png)

I'm no sure if more information should be displayed from source token, wdyt?

Security profile panel result:

![security_token_profile_panel](https://cloud.githubusercontent.com/assets/2028198/26705860/f7a64054-4706-11e7-9eef-6cd6b7365738.png)

Commits
-------

a3253f6 [SecurityBundle] Add user impersonation info and exit action to the profiler
@fabpot fabpot closed this Jun 21, 2017
@yceruto yceruto deleted the impersonation branch June 21, 2017 20:16
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@linaori linaori linaori left review comments

@ogizanagi ogizanagi ogizanagi left review comments

@noniagriconomie noniagriconomie noniagriconomie left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature Status: Needs Review WebProfilerBundle
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
8 participants
@yceruto @nicolas-grekas @ogizanagi @fabpot @stof @linaori @noniagriconomie @carsonbot