[Process] Deprecate ProcessBuilder #23111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jun 8, 2017
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
fabpot
approved these changes
Jun 9, 2017
pierredup
reviewed
Jun 9, 2017
| @@ -11,13 +11,17 @@ | |||
|
|
|||
| namespace Symfony\Component\Process; | |||
|
|
|||
| @trigger_error(sprintf('The %s class is deprecated since version 3.4 and will be removed in 4.0. Use the Process class instead.', __METHOD__), ProcessBuilder::class); | |||
There was a problem hiding this comment.
The arguments at the end needs to be , ProcessBuilder::class), E_USER_DEPRECATED);
fc7406a to
3aa8861
Compare
romainneutron
approved these changes
Jun 9, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jun 9, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [Process] Deprecate ProcessBuilder | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 3aa8861 [Process] Deprecate ProcessBuilder
|
Please, whenever you deprecate something, add a small comment explaining the main reasons. Thanks! |
|
The reason here is that the main use case for the ProcessBuilder was to escape the individual parts of the command for you. And this is now supported by the Process class itself by passing an array as the command (where it will escape each element of the array and build the final string command). The ProcessBuilder even relies on this feature now. |
fabpot
added a commit
to sensiolabs/SensioGeneratorBundle
that referenced
this pull request
Jul 17, 2017
…avier) This PR was squashed before being merged into the 3.1.x-dev branch (closes #564). Discussion ---------- Fix deprecation notice in test (ProcessBuilder) Backward- and forward-compatible fix for ``` Remaining deprecation notices (1) The Symfony\Component\Process\ProcessBuilder class is deprecated since version 3.4 and will be removed in 4.0. Use the Process class instead: 1x 1x in KernelManipulatorTest::testAddToArray from Sensio\Bundle\GeneratorBundle\Tests\Manipulator ``` Relevant commits: - symfony/process@201c3bd (PR symfony/symfony#23111) - symfony/process@e34416d (PR symfony/symfony#21474) - symfony/process@0743280 (PR symfony/symfony#23498) I also considered the simpler test `\Symfony\Component\HttpKernel\Kernel::VERSION_ID >= 30400` but it seems less reliable (version constant _vs_ code, possibly different versions of `symfony/http-kernel` _vs_ `symfony/process`). Commits ------- 5fe7d3e Fix deprecation notice in test (ProcessBuilder)
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.