[FrameworkBundle] 3.3: Don't get() private services from debug:router #23371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Jul 4, 2017
|
Imo this should become a service and get it injected, which solves the problem |
|
Sure, but making it a service in lower branches is a no-go I guess, as it'll require introducing new deprecations. But it can be done in 3.4. |
|
It doesn't require any deprec to me, the router dependency must stay lazy, that gives a container aware command registered as a service. Not sure if it's worth it, but see #23377 |
fabpot
approved these changes
Jul 4, 2017
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Jul 4, 2017
…ebug:router (ogizanagi) This PR was merged into the 3.3 branch. Discussion ---------- [FrameworkBundle] 3.3: Don't get() private services from debug:router | Q | A | ------------- | --- | Branch? | 3.3 <!-- see comment below --> | Bug fix? | yes | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #23366 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Same as #23366 but another place exist in upper branches. However, the original fix prevents using the proper name parser in case it was replaced 😕 . Commits ------- c75e486 [FrameworkBundle] 3.3: Don't get() private services from debug:router
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #23366 but another place exist in upper branches.
However, the original fix prevents using the proper name parser in case it was replaced 😕 .