[TwigBridge] cleaner implementation of the TwigRenderer #23435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tobion
commented
Jul 6, 2017
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #23432 (comment) |
| License | MIT |
| Doc PR |
Tobion
commented
Jul 6, 2017
| /** | ||
| * Returns the engine used by this renderer. | ||
| * | ||
| * @return TwigRendererEngineInterface The renderer engine |
There was a problem hiding this comment.
this is added so that static code analysis and autocomplete works (which I assume is the also the only reason the private engine property was overwritten)
There was a problem hiding this comment.
IMO adding autocomplete for deprecated method isn't worth it. It seems autocomplete for it never worked.
|
Thank you @Tobion. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 13, 2017
…(Tobion) This PR was merged into the 2.7 branch. Discussion ---------- [TwigBridge] cleaner implementation of the TwigRenderer | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #23432 (comment) | License | MIT | Doc PR | <!-- - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the 3.4, legacy code removals go to the master branch. - Please fill in this template according to the PR you're about to submit. - Replace this comment by a description of what your PR is solving. --> Commits ------- c7c5ba8 [TwigBridge] cleaner implementation of the TwigRenderer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.