Skip to content

[FrameworkBundle] Make RouterCacheWarmer implement ServiceSubscriberInterface #23570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2017
Merged

[FrameworkBundle] Make RouterCacheWarmer implement ServiceSubscriberInterface #23570

merged 1 commit into from
Jul 18, 2017

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 3.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Blocks #23569

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jul 18, 2017
@nicolas-grekas nicolas-grekas changed the title [FrameworkBundle] Make RouterCacheWarmer final and implement ServiceSubscriberInterface [FrameworkBundle] Make RouterCacheWarmer implement ServiceSubscriberInterface Jul 18, 2017
@nicolas-grekas nicolas-grekas force-pushed the router-warmer branch 3 times, most recently from 4dce714 to 13a6fda Compare July 18, 2017 11:42
@nicolas-grekas nicolas-grekas mentioned this pull request Jul 18, 2017
Merged
@fabpot
Copy link
Member

fabpot commented Jul 18, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit c0af003 into symfony:3.4 Jul 18, 2017
fabpot added a commit that referenced this pull request Jul 18, 2017
@fabpot
feature #23570 [FrameworkBundle] Make RouterCacheWarmer implement Ser…
5a521bf 
…viceSubscriberInterface (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] Make RouterCacheWarmer implement ServiceSubscriberInterface

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Blocks #23569

Commits
-------

c0af003 [FrameworkBundle] Make RouterCacheWarmer implement ServiceSubscriberInterface
@nicolas-grekas nicolas-grekas deleted the router-warmer branch July 18, 2017 13:12
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Deprecation Feature FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @fabpot @xabbuh @carsonbot