[VarDumper] Move locale sniffing to dump() time #23574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jul 18, 2017
•
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #23572 |
| License | MIT |
| Doc PR | - |
nicolas-grekas
commented
Jul 18, 2017
| @@ -121,6 +119,9 @@ public function setIndentPad($pad) | |||
| */ | |||
| public function dump(Data $data, $output = null) | |||
| { | |||
| $this->decimalPoint = strval(0.5); | |||
There was a problem hiding this comment.
sorry fabbot, but I really want strval here, to prevent any optim by opcache :)
2605cf0 to
f77161b
Compare
f77161b to
7f6e0da
Compare
7f6e0da to
eed8a51
Compare
fabpot
reviewed
Jul 19, 2017
| $this->decimalPoint = (string) 0.5; | ||
| $this->decimalPoint = $this->decimalPoint[1]; | ||
| $this->decimalPoint = localeconv(); | ||
| $this->decimalPoint = $this->decimalPoint['decimal_point']; |
There was a problem hiding this comment.
Why keep the logic here as well? Can't we remove it?
There was a problem hiding this comment.
For BC, the property is protected.
fabpot
approved these changes
Jul 19, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jul 19, 2017
…rekas) This PR was merged into the 2.7 branch. Discussion ---------- [VarDumper] Move locale sniffing to dump() time | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23572 | License | MIT | Doc PR | - Commits ------- eed8a51 [VarDumper] Move locale sniffing to dump() time
This was referenced Aug 1, 2017
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.