[Lock] Deprecate Filesystem/LockHandler #23724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e86806c to
1229371
Compare
chalasr
requested changes
Jul 31, 2017
| @@ -11,6 +11,8 @@ | |||
|
|
|||
| namespace Symfony\Component\Filesystem; | |||
|
|
|||
| @trigger_error(sprintf('The %s class is deprecated since version 3.4 and will be removed in 4.0. Use the SemaphoreStore or FlockStore class instead.', LockHandler::class), E_USER_DEPRECATED); | |||
|
|
|||
| use Symfony\Component\Filesystem\Exception\IOException; | |||
|
|
|||
| /** | |||
| @@ -11,6 +11,8 @@ | |||
|
|
|||
| namespace Symfony\Component\Filesystem; | |||
|
|
|||
| @trigger_error(sprintf('The %s class is deprecated since version 3.4 and will be removed in 4.0. Use the SemaphoreStore or FlockStore class instead.', LockHandler::class), E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
getting this notice while using the standalone filesystem, I would try to find the SemaphoreStore in the filesystem component. I would use FQCNs or prepend Lock here
UPGRADE-3.4.md
Outdated
| @@ -62,7 +69,7 @@ FrameworkBundle | |||
| * The `Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\TranslatorPass` | |||
| class has been deprecated and will be removed in 4.0. Use the | |||
| `Symfony\Component\Translation\DependencyInjection\TranslatorPass` class instead. | |||
|
|
|||
1dde55b to
33ab87f
Compare
|
fabbot needs some love |
33ab87f to
8a80505
Compare
8a80505 to
67ecc71
Compare
fabpot
approved these changes
Aug 1, 2017
|
Thank you @jderusse. |
fabpot
added a commit
that referenced
this pull request
Aug 1, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [Lock] Deprecate Filesystem/LockHandler | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#8243 This PR deprecate the `Filesystem\LockHandler` in favor of `Lock\SemaphoreStore` and `Lock\FlockStore`. Commits ------- 67ecc71 Deprecate Filesystem/LockHandler
nicolas-grekas
added a commit
that referenced
this pull request
Aug 3, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [Lock] Remove Filesystem\LockHandler | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | not yet | Fixed tickets | / | License | MIT | Doc PR | / This PR remove the deprecated LockHandler by #23724 Test won't pass as long as the branch 3.4 (and fixed deprecated tests) is not merged back into master. Commits ------- 39ab789 Remove Filesystem\LockHandler
fabpot
added a commit
that referenced
this pull request
Sep 1, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [Lock] Remove old version check | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23724 | License | MIT | Doc PR | / Because minimal required version PHP is currenty 7.1.3. ping @jderusse Commits ------- d817f98 Remove old version check
Merged
Merged
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jan 9, 2018
…eguiluz) This PR was merged into the 3.4 branch. Discussion ---------- [Lock] Deprecate Filesystem/LockHandler This PR deprecate the Filesystem\LockHandler in favor of Lock\SemaphoreStore and Lock\FlockStore. see: symfony/symfony#23724 Commits ------- cb771c3 Reword af6dc34 Minor reword 800bdd7 Deprecate Filesystem/LockHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecate the
Filesystem\LockHandlerin favor ofLock\SemaphoreStoreandLock\FlockStore.