[SecurityBundle] Rename init:acl to acl:init #23811
Conversation
ro0NL
commented
Aug 6, 2017
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #... |
| License | MIT |
| Doc PR | symfony/symfony-docs#... |
|
I'd would prefer that we finally move everything related to ACLs into another bundle that can be moved outside of Symfony core. Probably directly into |
|
See symfony/acl-bundle#2 :) but that needs a update anyway, so perhaps we can do this still here. |
|
I'll simply do the same changes in that bundle so they remain in sync |
|
👍 not sure how this goes.. if the commands stay in core till 4.0 i think the rename makes sense. In the acl bundle we can do the rename instantly i guess, without deprecation. |
|
@ro0NL I've simply copied your changes to keep them in sync, the deprecation makes sense as we can release a 4.0 variant of that bundle without problems. As long as people use 3.4 and use the ACL (bundle), they should be able to plug and play without BC breaks |
|
Thanks for sending!
…
On Aug 22, 2017 at 3:50 AM, <Amrouche Hamza ***@***.***)> wrote:
@Simperfit approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub (#23811 (review)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AOXMGFzd6TCARO2fweBXNmige95Vz5wbks5saohPgaJpZM4OuxyS).
|
|
Let's deprecate ACL code and rename it in symfony/acl-bundle directly. See #24318 |
|
Favoring #24318 :) |
This PR was merged into the 3.4 branch. Discussion ---------- [SecurityBundle] Deprecate ACL related code | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes/no | Fixed tickets | replaces #23811 | License | MIT | Doc PR | todo Needs symfony/acl-bundle#2 Commits ------- e3b7dc5 [SecurityBundle] Deprecate ACL related code