[SecurityBundle] Deprecate ACL related code #24318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2496377 to
69eb41f
Compare
javiereguiluz
approved these changes
Sep 25, 2017
| @@ -93,7 +89,8 @@ protected function configure() | |||
| */ | |||
| protected function execute(InputInterface $input, OutputInterface $output) | |||
| { | |||
| // BC to be removed in 4.0 | |||
| (new SymfonyStyle($input, $output instanceof ConsoleOutputInterface ? $output->getErrorOutput() : $output))->warning('Command "init:acl" is deprecated since version 3.4 and will be removed from SecurityBundle in 4.0. Register symfony/acl-bundle and use "acl:init" instead.'); | |||
There was a problem hiding this comment.
Register symfony/acl-bundle and use ... -> Install symfony/acl-bundle and use ... ?
| @@ -117,7 +117,8 @@ protected function configure() | |||
| */ | |||
| protected function execute(InputInterface $input, OutputInterface $output) | |||
| { | |||
| // BC to be removed in 4.0 | |||
| (new SymfonyStyle($input, $output instanceof ConsoleOutputInterface ? $output->getErrorOutput() : $output))->warning('Command "acl:set" is deprecated since version 3.4 and will be removed from SecurityBundle in 4.0. Register symfony/acl-bundle instead.'); | |||
There was a problem hiding this comment.
Register symfony/acl-bundle instead. -> Install symfony/acl-bundle to use this command. ?
69eb41f to
d45e296
Compare
gusdecool
approved these changes
Sep 25, 2017
nicolas-grekas
approved these changes
Sep 26, 2017
d45e296 to
9d2137d
Compare
9d2137d to
e3b7dc5
Compare
weaverryan
approved these changes
Sep 26, 2017
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Sep 26, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [SecurityBundle] Deprecate ACL related code | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes/no | Fixed tickets | replaces #23811 | License | MIT | Doc PR | todo Needs symfony/acl-bundle#2 Commits ------- e3b7dc5 [SecurityBundle] Deprecate ACL related code
fabpot
added a commit
that referenced
this pull request
Sep 27, 2017
…tion (ogizanagi) This PR was merged into the 3.4 branch. Discussion ---------- [SecurityBundle] Add missing AclSchemaListener deprecation | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | yes <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Missing from #24318 Commits ------- d43c1f7 [SecurityBundle] Add missing AclSchemaListener deprecation
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs symfony/acl-bundle#2