[Lock] Fix/lock test #23847
Merged
[Lock] Fix/lock test #23847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e8ac63 to
919a1c0
Compare
919a1c0 to
ff95169
Compare
|
Thank you @jderusse. |
fabpot
added a commit
that referenced
this pull request
Aug 10, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [Lock] Fix/lock test | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Test on the Lock component often fail, the purpose of this PR is to fix it. The goal of this failling test is to assert that blocking locks works. To test the blocking mode, I had to create 2 concurent process and I used pcntl_fork for that. Sadly, travis takes more time to fork the process than configured TTL. This PR replace the previous "sleep" to let child and parent starts, by a pcntl communication between child and parent. | Process 1 | Process 2 | ----------------------- | ---------- | Wait N°2 | | | Acquire Lock | | Send signal to N°1 | Wake up | Wait N°1 | Try lock(non block) | | => assert failure | | Send signal to N°2 | | lock(block) | Wake up | .. | sleep 50 000ms | .. | .. | .. | Release lock | => assert Acquired | exit | Release lock | | => assert child exit 0 | Commits ------- ff95169 Fix lock failling test
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test on the Lock component often fail, the purpose of this PR is to fix it.
The goal of this failling test is to assert that blocking locks works. To test the blocking mode, I had to create 2 concurent process and I used pcntl_fork for that.
Sadly, travis takes more time to fork the process than configured TTL.
This PR replace the previous "sleep" to let child and parent starts, by a pcntl communication between child and parent.