Skip to content

[Lock] Fix/lock test #23847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2017
Merged

[Lock] Fix/lock test #23847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions src/Symfony/Component/Lock/Tests/Store/BlockingStoreTestTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ abstract protected function getStore();
public function testBlockingLocks()
{
// Amount a microsecond used to order async actions
$clockDelay = 200000;
$clockDelay = 50000;

if (\PHP_VERSION_ID < 50600 || defined('HHVM_VERSION_ID')) {
$this->markTestSkipped('The PHP engine does not keep resource in child forks');
Expand All @@ -46,31 +46,46 @@ public function testBlockingLocks()
/** @var StoreInterface $store */
$store = $this->getStore();
$key = new Key(uniqid(__METHOD__, true));
$parentPID = posix_getpid();

if ($childPID1 = pcntl_fork()) {
// give time to fork to start
usleep(1 * $clockDelay);
// Block SIGHUP signal
pcntl_sigprocmask(SIG_BLOCK, array(SIGHUP));

if ($childPID = pcntl_fork()) {
// Wait the start of the child
pcntl_sigwaitinfo(array(SIGHUP), $info);

try {
// This call should failed given the lock should already by acquired by the child #1
// This call should failed given the lock should already by acquired by the child
$store->save($key);
$this->fail('The store saves a locked key.');
} catch (LockConflictedException $e) {
}

// send the ready signal to the child
posix_kill($childPID, SIGHUP);

// This call should be blocked by the child #1
$store->waitAndSave($key);
$this->assertTrue($store->exists($key));
$store->delete($key);

// Now, assert the child process worked well
pcntl_waitpid($childPID1, $status1);
pcntl_waitpid($childPID, $status1);
$this->assertSame(0, pcntl_wexitstatus($status1), 'The child process couldn\'t lock the resource');
} else {
// Block SIGHUP signal
pcntl_sigprocmask(SIG_BLOCK, array(SIGHUP));
try {
$store->save($key);
// Wait 2 ClockDelay to let parent process to finish
usleep(2 * $clockDelay);
// send the ready signal to the parent
posix_kill($parentPID, SIGHUP);

// Wait for the parent to be ready
pcntl_sigwaitinfo(array(SIGHUP), $info);

// Wait ClockDelay to let parent assert to finish
usleep($clockDelay);
$store->delete($key);
exit(0);
} catch (\Exception $e) {
Expand Down