[Form] Display general forms information on debug:form #24185

yceruto · 2017-09-13T12:38:39Z

Q	A
Branch?	3.4
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-
License	MIT
Doc PR	-

When we run bin/console debug:form (without argument) all possible Form Component information is displayed.

ro0NL · 2017-09-13T13:29:28Z

src/Symfony/Component/Form/Console/Descriptor/JsonDescriptor.php

+    protected function describeDefaults(array $options = array())
+    {
+        $data['builtin_form_types'] = $this->getCoreTypes();
+        $data['services_form_types'] = array_values(array_diff($options['types'], $data['builtin_form_types']));


builtin types will be all from $options['types'] within Symfony\Component\Form\Extension\Core\Type\ namespace no? Isnt that more easy to do instead of getCoreTypes hack.

Also i prefer services types to be shown above built in ones. Personal pref though.

builtin types will be all from $options['types'] within Symfony\Component\Form\Extension\Core\Type\ namespace no?

Nope, only those registered, the most of them aren't services.

Got it. Perhaps add static getter for that in FormRegistry, as little new feat. But reflection is fine as well i guess xD

Perhaps add static getter for that in FormRegistry, as little new feat.

Not sure how to do that, because "types" is concern of FormExtensionInterface instances and loadTypes() method or types property after initTypes() in AbstractExtension (both inaccessible directly) so would need hack it anyway.

My idea was FormRegistry::getCoreTypes with the implem. of CoreExtension::loadTypes which in turn does simply return FormRegistry::getCoreTypes();.

For this PR you'd use FormRegistry::getCoreTypes() as well. CoreExtension::getTypes might do also :)

Yep, still not sure if worth it just for debug purpose. Thanks!

ogizanagi

I'm still a bit worried about the fact the command does only list types registered as a service, which can be a bit confusing for users not finding their own types or some third party ones. But the fact you explicit the "core types" and "services types" sections looks enough to me.

ogizanagi · 2017-09-13T17:12:28Z

src/Symfony/Component/Form/Tests/Fixtures/Descriptor/defaults_1.txt

+[33mBuilt-in form types[39m
+[33m-------------------[39m
+
+ * Symfony\Component\Form\Extension\Core\Type\FormType


Just wondering: What about removing the namespace for core types when using the txt descriptor? (perhaps mentioning it only once above, in a comment or the section).

A long list of short words is also not ideal btw. But 👍 for using short names anyway. Perhaps play a bit with comma separated variants.

👍 Improved core types representation.

yceruto · 2017-09-13T18:19:04Z

Screenshot updated!

ro0NL · 2017-09-13T18:34:23Z

alpha order?

yceruto · 2017-09-13T19:37:10Z

I'm still a bit worried about the fact the command does only list types registered as a service, which can be a bit confusing for users not finding their own types or some third party ones...

@ogizanagi we know the path of installed bundles, we have best practices that say us the directory where would put the form types, what do you think about a discovery option to search subclasses of AbstractType using the Finder component? This operation we would only do it using --vvv option. (in another PR)

yceruto · 2017-09-13T22:38:14Z

Just updating the help description.

ogizanagi · 2017-09-14T06:00:03Z

we know the path of installed bundles, we have best practices that say us the directory where would put the form types, what do you think about a discovery option to search subclasses of AbstractType using the Finder component?

Form types could be in so many places, including not in a bundle at all. Searching them by convention, which is more a beginner best practice than a canon, probably isn't a satisfying enough solution.

yceruto · 2017-09-14T13:40:45Z

Form types could be in so many places, including not in a bundle at all. Searching them by convention, which is more a beginner best practice than a canon, probably isn't a satisfying enough solution.

True, it was just a vague idea, I meant, Forms path best practices can be used first, later anywhere, but probably it would be too much.

ro0NL · 2017-09-14T13:47:08Z

Convenience wise i like the discovery of types with --discover or -v as proposed. Making this command so much more useful; we need to do something IMHO.

At least passing an arbitrary FQCN, which is a form type, should be allowed. Discovery wise i wouldnt be against a lookup in src/Form; src/**/Form; vendor/*/*/Form; vendor/*/*/**Form/.

yceruto · 2017-09-14T14:12:28Z

I have another PR ready for debug a form type "option" but I'd like avoid conflicts later with this one. Please @symfony/deciders or reviewers? @chalasr since you're familiarized with the command, can I ask for your opinion?

ro0NL · 2017-09-14T14:21:09Z

src/Symfony/Component/Form/Console/Descriptor/TextDescriptor.php

+    {
+        $coreTypes = $this->getCoreTypes();
+
+        $this->output->section('Built-in form types (Symfony\Component\Form\Extension\Core\Type)');


not bound to OutputInterface but StyleInterface. Are we being pragmatic here? Should we?

$output = $this->output instanceof StyleInterface ? $this->ouput : new SymfonyStyle($this->output);

?

Yep, we are subject to DescriptorInterface signature.

Fixed. Thanks!

ro0NL · 2017-09-14T14:22:42Z

src/Symfony/Component/Form/Tests/Fixtures/Descriptor/defaults_1.json

+        "Symfony\\Component\\Form\\Extension\\Core\\Type\\TimezoneType",
+        "Symfony\\Component\\Form\\Extension\\Core\\Type\\UrlType"
+    ],
+    "services_form_types": [


id sayservice_form_types (no double pluralization)

ogizanagi · 2017-09-15T16:33:58Z

Thanks Yonel.

… (yceruto) This PR was merged into the 3.4 branch. Discussion ---------- [Form] Display general forms information on debug:form | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - ![debug-form-defaults](https://user-images.githubusercontent.com/2028198/30436620-998103ca-993a-11e7-9873-31f042327374.png) When we run `bin/console debug:form` (without argument) all possible Form Component information is displayed. Commits ------- 12d1a7f Display form defaults on debug:form

…e (yceruto, ogizanagi) This PR was merged into the 3.4 branch. Discussion ---------- [Form] Display option definition from a given form type | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes (deps=high failure expected) | Fixed tickets | - | License | MIT | Doc PR | - ![debug-form-option](https://user-images.githubusercontent.com/2028198/30569305-12a30738-9ca8-11e7-98b7-6eaf78d3d5a7.png) Show friendly message if typo: ![debug-form-not-found](https://user-images.githubusercontent.com/2028198/30450999-83d58b56-9960-11e7-8705-b60ba33baf48.png) complement of symfony/symfony#24185 Commits ------- d6d187d26e Add & use OptionResolverIntrospector 8bbb5e7884 Add debug:form type option

…e (yceruto, ogizanagi) This PR was merged into the 3.4 branch. Discussion ---------- [Form] Display option definition from a given form type | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes (deps=high failure expected) | Fixed tickets | - | License | MIT | Doc PR | - ![debug-form-option](https://user-images.githubusercontent.com/2028198/30569305-12a30738-9ca8-11e7-98b7-6eaf78d3d5a7.png) Show friendly message if typo: ![debug-form-not-found](https://user-images.githubusercontent.com/2028198/30450999-83d58b56-9960-11e7-8705-b60ba33baf48.png) complement of #24185 Commits ------- d6d187d Add & use OptionResolverIntrospector 8bbb5e7 Add debug:form type option

carsonbot added Status: Needs Review Form Feature labels Sep 13, 2017

nicolas-grekas added this to the 3.4 milestone Sep 13, 2017

ro0NL reviewed Sep 13, 2017

View reviewed changes

yceruto force-pushed the debug_form_defaults branch from c692654 to 5678081 Compare September 13, 2017 17:06

ogizanagi approved these changes Sep 13, 2017

View reviewed changes

yceruto force-pushed the debug_form_defaults branch from 5678081 to 01eda09 Compare September 13, 2017 18:14

yceruto force-pushed the debug_form_defaults branch from 01eda09 to e418d14 Compare September 13, 2017 18:46

yceruto force-pushed the debug_form_defaults branch from e418d14 to efe4180 Compare September 13, 2017 22:35

ro0NL reviewed Sep 14, 2017

View reviewed changes

yceruto force-pushed the debug_form_defaults branch from f846fc6 to 78d1780 Compare September 14, 2017 14:41

yceruto changed the title ~~[Form] Display form defaults in debug:form~~ [Form] Display forms information on debug:form Sep 14, 2017

yceruto changed the title ~~[Form] Display forms information on debug:form~~ [Form] Display general forms information on debug:form Sep 14, 2017

ro0NL approved these changes Sep 14, 2017

View reviewed changes

yceruto mentioned this pull request Sep 14, 2017

[Form] Display option definition from a given form type #24208

Merged

chalasr approved these changes Sep 14, 2017

View reviewed changes

Display form defaults on debug:form

12d1a7f

ogizanagi force-pushed the debug_form_defaults branch from 78d1780 to 12d1a7f Compare September 15, 2017 16:16

ogizanagi merged commit 12d1a7f into symfony:3.4 Sep 15, 2017

yceruto deleted the debug_form_defaults branch September 15, 2017 16:43

javiereguiluz mentioned this pull request Oct 3, 2017

[Form] Add debug:form command symfony/symfony-docs#8361

Closed

This was referenced Oct 18, 2017

Release v3.4.0-BETA1 #24609

Merged

Release v4.0.0-BETA1 #24612

Merged

yceruto mentioned this pull request Feb 7, 2018

Symfony form information Nyholm/symfony-bootstrap-form#4

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Form] Display general forms information on debug:form #24185

[Form] Display general forms information on debug:form #24185

yceruto commented Sep 13, 2017 •

edited

Loading

ro0NL Sep 13, 2017

ro0NL Sep 13, 2017

yceruto Sep 13, 2017

ro0NL Sep 13, 2017

yceruto Sep 13, 2017 •

edited

Loading

ro0NL Sep 13, 2017 •

edited

Loading

yceruto Sep 13, 2017 •

edited

Loading

ro0NL Sep 13, 2017

ogizanagi left a comment

ogizanagi Sep 13, 2017

ro0NL Sep 13, 2017 •

edited

Loading

yceruto Sep 13, 2017

ro0NL Sep 13, 2017

yceruto commented Sep 13, 2017

ro0NL commented Sep 13, 2017

yceruto commented Sep 13, 2017

yceruto commented Sep 13, 2017

ogizanagi commented Sep 14, 2017

yceruto commented Sep 14, 2017

ro0NL commented Sep 14, 2017

yceruto commented Sep 14, 2017

ro0NL Sep 14, 2017 •

edited

Loading

yceruto Sep 14, 2017

yceruto Sep 14, 2017 •

edited

Loading

ro0NL Sep 14, 2017

yceruto Sep 14, 2017

ogizanagi commented Sep 15, 2017

[Form] Display general forms information on debug:form #24185

[Form] Display general forms information on debug:form #24185

Conversation

yceruto commented Sep 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yceruto Sep 13, 2017 • edited Loading

Choose a reason for hiding this comment

ro0NL Sep 13, 2017 • edited Loading

Choose a reason for hiding this comment

yceruto Sep 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ogizanagi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ro0NL Sep 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yceruto commented Sep 13, 2017

ro0NL commented Sep 13, 2017

yceruto commented Sep 13, 2017

yceruto commented Sep 13, 2017

ogizanagi commented Sep 14, 2017

yceruto commented Sep 14, 2017

ro0NL commented Sep 14, 2017

yceruto commented Sep 14, 2017

ro0NL Sep 14, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yceruto Sep 14, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ogizanagi commented Sep 15, 2017

yceruto commented Sep 13, 2017 •

edited

Loading

yceruto Sep 13, 2017 •

edited

Loading

ro0NL Sep 13, 2017 •

edited

Loading

yceruto Sep 13, 2017 •

edited

Loading

ro0NL Sep 13, 2017 •

edited

Loading

ro0NL Sep 14, 2017 •

edited

Loading

yceruto Sep 14, 2017 •

edited

Loading