[Form] Display option definition from a given form type #24208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've used |
aea9fa1 to
d704551
Compare
|
Color is auto-enabled only when writing to a color-enabled output stream. You can force it, but then it's your responsibility to do it appropriately, see eg |
0a45775 to
b71aed9
Compare
|
@nicolas-grekas perfect thanks! color enabled. |
| protected function describeOption(OptionsResolver $optionsResolver, array $options = array()) | ||
| { | ||
| $this->dumper = new CliDumper(null, null, CliDumper::DUMP_LIGHT_ARRAY | CliDumper::DUMP_COMMA_SEPARATOR); | ||
| $this->dumper->setColors(true); |
There was a problem hiding this comment.
s/true/$this->output->isDecorated()/
67cddf1 to
751de48
Compare
|
Is dumping a closure like the normalizer ones really useful? At least perhaps registering a dedicated caster to only keep file and line no? |
|
Status: Needs Work |
3c548a7 to
e9d49c2
Compare
|
Unrelated to this command argument but I added type alternatives if typo on |
9e90c8a to
20e9af2
Compare
|
@nicolas-grekas: Regarding #24208 (comment), does this look okay to you? Thank you. |
006105f to
c4e6958
Compare
ogizanagi
approved these changes
Sep 29, 2017
|
I'm going to merge this (unless there is any objection) before feature freeze, so the whole |
|
I'd prefer to finish everything properly instead of rushing out anything. That would not make sense. We can still merge things next week if needed. there is no hard date. |
|
Alright :) |
c4e6958 to
4c07a0e
Compare
|
Just rebasing & resolving conflicts :) |
ed0986e to
7b44ca0
Compare
7b44ca0 to
d6d187d
Compare
nicolas-grekas
approved these changes
Oct 8, 2017
javiereguiluz
approved these changes
Oct 8, 2017
fabpot
approved these changes
Oct 8, 2017
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Oct 9, 2017
…e (yceruto, ogizanagi) This PR was merged into the 3.4 branch. Discussion ---------- [Form] Display option definition from a given form type | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes (deps=high failure expected) | Fixed tickets | - | License | MIT | Doc PR | -  Show friendly message if typo:  complement of #24185 Commits ------- d6d187d Add & use OptionResolverIntrospector 8bbb5e7 Add debug:form type option
This was referenced Oct 18, 2017
Merged
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Mar 24, 2019
This PR was squashed before being merged into the 4.3-dev branch (closes #28898). Discussion ---------- [Console] Add dumper | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#10502 This PR adds a new `Dumper` helper in the Console component. As there are 2 types of dumps - debug purpose (e.g. `dd()`, `dump()`) - output purpose (see #24208, #27684) For the latter we cannot use the global system (debug) dumper, i.e. `VarDumper::dump()`, we need something tied to the current output and dependency free. Here it is: ```php $io = new SymfonyStyle($input, $output); $dumper = new Dumper($io); $io->writeln($dumper([-0.5, 0, 1])); $io->writeln($dumper(new \stdClass())); $io->writeln($dumper(123)); $io->writeln($dumper('foo')); $io->writeln($dumper(null)); $io->writeln($dumper(true)); ``` With VarDumper comonent:  Without:  > #27684 (comment) var-dumper is not a mandatory dep of fwb, can we do without? Now we can :) Commits ------- fc7465c [Console] Add dumper
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jul 20, 2023
This PR was submitted for the 6.4 branch but it was squashed and merged into the 5.4 branch instead. Discussion ---------- add `OptionsResolverIntrospector`usage doc <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Original commit : symfony/symfony@d6d187d Orignal PR : symfony/symfony#24208 Commits ------- 887f6f5 add `OptionsResolverIntrospector`usage doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show friendly message if typo:
complement of #24185