[FrameworkBundle] allow forms without translations and validator #24303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
approved these changes
Sep 24, 2017
nicolas-grekas
approved these changes
Sep 24, 2017
fabpot
approved these changes
Sep 24, 2017
|
Thank you @xabbuh. |
This was referenced Sep 24, 2017
fabpot
added a commit
that referenced
this pull request
Sep 24, 2017
… validator (xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] allow forms without translations and validator | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/flex#26, symfony/recipes#191, symfony/recipes#193 | License | MIT | Doc PR | The Form component is perfectly usable without the Translation and Validator components. We should allow the same when using the FrameworkBundle to improve the user experience in Symfony Flex applications (see the linked issue). Commits ------- cb6ead1 allow forms without translations and validator
|
forms without the translation component works only if you create your own form theme though (or never use the form rendering), as the core theme relies on |
fabpot
added a commit
that referenced
this pull request
Sep 28, 2017
…ck (xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [TwigBundle] register an identity translator as fallback | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24303 (comment) | License | MIT | Doc PR | The Form component can be used without the Translation component. However, to be able to use the default form themes provided by the TwigBridge you need to have the `trans` filter to be available. This change ensure that there will always be a `trans` filter which as a fallback will just return the message key if no translator is present. Commits ------- f0876e5 register an identity translator as fallback
symfony-splitter
pushed a commit
to symfony/twig-bundle
that referenced
this pull request
Sep 28, 2017
…ck (xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [TwigBundle] register an identity translator as fallback | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#24303 (comment) | License | MIT | Doc PR | The Form component can be used without the Translation component. However, to be able to use the default form themes provided by the TwigBridge you need to have the `trans` filter to be available. This change ensure that there will always be a `trans` filter which as a fallback will just return the message key if no translator is present. Commits ------- f0876e5927 register an identity translator as fallback
This was referenced Oct 18, 2017
Merged
Merged
This was referenced Nov 4, 2017
fabpot
added a commit
that referenced
this pull request
Nov 5, 2017
… present (weaverryan) This PR was merged into the 3.4 branch. Discussion ---------- symfony/form auto-enables symfony/validator, even when not present | Q | A | ------------- | --- | Branch? | 3.4 or master / 2.7, 2.8 or 3.3 <!-- see comment below --> | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | not needed In #24303, we allowed form to be used without the validator component. But, there is a small problem with the logic: the validation system is set to enabled, even if it is not present. If you install form but NOT validator, you see the error: > Validation support cannot be enabled as the Validator component is not installed. Assuming the form system really is usable without validation, this should be an easy merge. Commits ------- 03c0254 Only enabling validation if it is present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Form component is perfectly usable without the Translation and Validator components. We should allow the same when using the FrameworkBundle to improve the user experience in Symfony Flex applications (see the linked issue).