symfony/form auto-enables symfony/validator, even when not present #24821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
approved these changes
Nov 5, 2017
fabpot
approved these changes
Nov 5, 2017
|
Thank you @weaverryan. |
fabpot
added a commit
that referenced
this pull request
Nov 5, 2017
… present (weaverryan) This PR was merged into the 3.4 branch. Discussion ---------- symfony/form auto-enables symfony/validator, even when not present | Q | A | ------------- | --- | Branch? | 3.4 or master / 2.7, 2.8 or 3.3 <!-- see comment below --> | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | not needed In #24303, we allowed form to be used without the validator component. But, there is a small problem with the logic: the validation system is set to enabled, even if it is not present. If you install form but NOT validator, you see the error: > Validation support cannot be enabled as the Validator component is not installed. Assuming the form system really is usable without validation, this should be an easy merge. Commits ------- 03c0254 Only enabling validation if it is present
This was referenced Nov 5, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #24303, we allowed form to be used without the validator component. But, there is a small problem with the logic: the validation system is set to enabled, even if it is not present. If you install form but NOT validator, you see the error:
Assuming the form system really is usable without validation, this should be an easy merge.