[Security][SecurityBundle] Deprecate the HTTP digest auth #24335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
commented
Sep 26, 2017
| @@ -111,7 +111,6 @@ public function testFirewalls() | |||
| 'remote_user', | |||
| 'form_login', | |||
| 'http_basic', | |||
| 'http_digest', | |||
There was a problem hiding this comment.
Instead of removing this now, we could mark the corresponding test case with @group legacy, but the test case must not be removed in 4.0.
There was a problem hiding this comment.
Or copy fixture container1.* as container1_with_digest.* and duplicate the test so that it can be removed in 4.0? (at least for this one)
chalasr
reviewed
Sep 26, 2017
| @@ -20,9 +20,18 @@ | |||
| * HttpDigestFactory creates services for HTTP digest authentication. | |||
| * | |||
| * @author Fabien Potencier <fabien@symfony.com> | |||
| * | |||
| * @deprecated since 3.4, to be removed in 4.0. | |||
There was a problem hiding this comment.
dot should be removed :) (same everywhere)
| @@ -111,7 +111,6 @@ public function testFirewalls() | |||
| 'remote_user', | |||
| 'form_login', | |||
| 'http_basic', | |||
| 'http_digest', | |||
There was a problem hiding this comment.
Or copy fixture container1.* as container1_with_digest.* and duplicate the test so that it can be removed in 4.0? (at least for this one)
|
UPGRADE-4.0 should be updated |
|
Missing UPGRADE-4.0 update done. |
chalasr
approved these changes
Sep 26, 2017
fabpot
approved these changes
Sep 26, 2017
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Sep 26, 2017
…uth (ogizanagi) This PR was merged into the 3.4 branch. Discussion ---------- [Security][SecurityBundle] Deprecate the HTTP digest auth | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | yes <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #24325 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A See #24336 for the removal PR on master. Commits ------- 11fe79d [Security][SecurityBundle] Deprecate the HTTP digest auth
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #24336 for the removal PR on master.