-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Security][SecurityBundle] Remove the HTTP digest auth #24336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can we remove the reference in https://github.com/symfony/symfony/tree/master/src/Symfony/Component/Security/Core/Resources/translations? |
Indeed. I spotted those ones, but forgotten to remove :) Thanks. |
chalasr
approved these changes
Sep 26, 2017
fabpot
added a commit
that referenced
this pull request
Sep 26, 2017
…uth (ogizanagi) This PR was merged into the 3.4 branch. Discussion ---------- [Security][SecurityBundle] Deprecate the HTTP digest auth | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | yes <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #24325 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A See #24336 for the removal PR on master. Commits ------- 11fe79d [Security][SecurityBundle] Deprecate the HTTP digest auth
symfony-splitter
pushed a commit
to symfony/security-http
that referenced
this pull request
Sep 26, 2017
…uth (ogizanagi) This PR was merged into the 3.4 branch. Discussion ---------- [Security][SecurityBundle] Deprecate the HTTP digest auth | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | yes <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #24325 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A See symfony/symfony#24336 for the removal PR on master. Commits ------- 11fe79d77f [Security][SecurityBundle] Deprecate the HTTP digest auth
symfony-splitter
pushed a commit
to symfony/security
that referenced
this pull request
Sep 26, 2017
…uth (ogizanagi) This PR was merged into the 3.4 branch. Discussion ---------- [Security][SecurityBundle] Deprecate the HTTP digest auth | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | yes <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #24325 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A See symfony/symfony#24336 for the removal PR on master. Commits ------- 11fe79d77f [Security][SecurityBundle] Deprecate the HTTP digest auth
@fabpot wrong closing? Needs a rebase and good to go. |
I didn't see that the commit from 3.4 was there, so it's merged in a weird way, but merged :) |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 26, 2019
…on (ro0NL) This PR was merged into the 4.2 branch. Discussion ---------- [Security] Cleanup "Digest nonce has expired." translation | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Running `php src/Symfony/Component/Translation/Resources/bin/translation-status.php` i see: ``` | Locale: nn | Translated: 16/15 | Locale: tl | Translated: 16/15 ``` Here's the cleanup. (ref #24336) Commits ------- e95445d [Security] Cleanup "Digest nonce has expired." translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged once #24335 is merged up from 3.4 to master.