[Session][VarDumper] Deprecate accepting legacy mongo extension #24438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it with the mongodb/mongodb package and ext-mongodb instead
fabpot
approved these changes
Oct 5, 2017
nicolas-grekas
approved these changes
Oct 5, 2017
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Oct 5, 2017
…extension (Tobion) This PR was squashed before being merged into the 3.4 branch (closes #24438). Discussion ---------- [Session][VarDumper] Deprecate accepting legacy mongo extension | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The old ext-mongo is deprecated and does not work with PHP 7. See http://php.net/manual/en/mongo.setup.php People should use mongodb/mongodb and ext-mongodb instead. This deprecates functionality using the old ext-mongo classes. Commits ------- d535ff6 [VarDumper] deprecate MongoCaster 6651af0 [HttpFoundation] deprecate using with the legacy mongo extension; use it with the mongodb/mongodb package and ext-mongodb instead
stof
reviewed
Oct 5, 2017
| * @author Markus Bachmann <markus.bachmann@bachi.biz> | ||
| * | ||
| * @see https://packagist.org/packages/mongodb/mongodb | ||
| * @see http://php.net/manual/en/set.mongodb.php |
There was a problem hiding this comment.
this should be changed everwhere then. we use http php.net documentation mostly
|
PR welcomed on master to remove the legacy code. |
|
On it. |
fabpot
added a commit
that referenced
this pull request
Oct 5, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [Session] remove deprecated session handlers | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | yes | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#8486 Removes deprecated session handler from #24389, #24438 and #24443 Commits ------- 0a7af3f [Session] remove deprecated session handlers
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old ext-mongo is deprecated and does not work with PHP 7. See http://php.net/manual/en/mongo.setup.php
People should use mongodb/mongodb and ext-mongodb instead. This deprecates functionality using the old ext-mongo classes.