[Form] Rename FormConfigBuilder::$nativeRequestProcessor private variable to ::$nativeRequestHandler
#25041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For 2.7 I guess as that's the lowest branch where this applies? |
…riable to `::$nativeRequestHandler`
aa80cca to
a35d4f8
Compare
|
@nicolas-grekas Sorry, made a mistake ;) Then I rebased onto 2.7. |
fabpot
approved these changes
Nov 21, 2017
Simperfit
approved these changes
Nov 21, 2017
xabbuh
approved these changes
Nov 21, 2017
|
Thank you @issei-m. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 21, 2017
…r` private variable to `::$nativeRequestHandler` (issei-m) This PR was merged into the 2.7 branch. Discussion ---------- [Form] Rename `FormConfigBuilder::$nativeRequestProcessor` private variable to `::$nativeRequestHandler` | Q | A | ------------- | --- | Branch? |2.7 | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | Not confirmed, but the changes are completely minor | Fixed tickets | - | License | MIT | Doc PR | - I guess the term "processor" had been used until [this PR comes](#7732), but hadn't been renamed properly at the time. And I think "handler" sounds more relevant to me anyway. Commits ------- a35d4f8 [Form] Rename `FormConfigBuilder::$nativeRequestProcessor` private variable to `::$nativeRequestHandler`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess the term "processor" had been used until this PR comes, but hadn't been renamed properly at the time.
And I think "handler" sounds more relevant to me anyway.