Skip to content

[Form] Renamed form processors to request handlers #7732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2013
Merged

[Form] Renamed form processors to request handlers #7732

merged 1 commit into from
Apr 20, 2013

Conversation

webmozart
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR symfony/symfony-docs#2092

@webmozart webmozart mentioned this pull request Apr 20, 2013
Merged
@fabpot
Copy link
Member

fabpot commented Apr 20, 2013

Can you explain the rationale behind this change?

@webmozart
Copy link
Contributor Author

Mainly code readability. "Processing" a form is very ambiguous, while handling a request should explain better what happens under the hood.

Example 1 (without HttpFoundation):
$form = $formFactory->createForm(...);

$form->handleRequest();

if ($form->isValid()) {
    // ...
}

vs.

$form = $formFactory->createForm(...);

$form->process();

if ($form->isValid()) {
    // ...
}
Example 2 (with HttpFoundation):
$form = $formFactory->createForm(...);

$form->handleRequest($request);

if ($form->isValid()) {
    // ...
}

vs.

$form = $formFactory->createForm(...);

$form->process($request);

if ($form->isValid()) {
    // ...
}

fabpot added a commit that referenced this pull request Apr 20, 2013
@fabpot
merged branch bschussek/improve-naming (PR #7732)
a00d7dc 
This PR was merged into the master branch.

Discussion
----------

[Form] Renamed form processors to request handlers

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | symfony/symfony-docs#2092

Commits
-------

ae7c378 [Form] Renamed form processors to request handlers
@fabpot fabpot closed this Apr 20, 2013
@fabpot fabpot merged commit ae7c378 into symfony:master Apr 20, 2013
@issei-m issei-m mentioned this pull request Nov 20, 2017
Merged
nicolas-grekas added a commit that referenced this pull request Nov 21, 2017
@nicolas-grekas
minor #25041 [Form] Rename `FormConfigBuilder::$nativeRequestProcesso…
efd9a5a 
…r` private variable to `::$nativeRequestHandler` (issei-m)

This PR was merged into the 2.7 branch.

Discussion
----------

[Form] Rename `FormConfigBuilder::$nativeRequestProcessor` private variable to `::$nativeRequestHandler`

| Q             | A
| ------------- | ---
| Branch?       |2.7
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | Not confirmed, but the changes are completely minor
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

I guess the term "processor" had been used until [this PR comes](#7732), but hadn't been renamed properly at the time.
And I think "handler" sounds more relevant to me anyway.

Commits
-------

a35d4f8 [Form] Rename `FormConfigBuilder::$nativeRequestProcessor` private variable to `::$nativeRequestHandler`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@webmozart @fabpot @lyrixx @stof @wtcross