[Bridge/PhpUnit] fix installation path #25068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbourigault
reviewed
Nov 21, 2017
| passthru("$COMPOSER require --no-update symfony/phpunit-bridge \"*\""); | ||
| if (file_exists($path)) { | ||
| if (file_exists($path = $root.'/vendor/symfony/phpunit-bridge')) { | ||
| passthru("$COMPOSER require --no-update symfony/phpunit-bridge \"*@dev\""); |
There was a problem hiding this comment.
Wouldn't this install a dev version even if a stable version is installed in the project?
There was a problem hiding this comment.
When the "path" repo is used, the package there is at version "dev-master"
since that's the one we really want to install, we have to put this.
nicolas-grekas
added a commit
that referenced
this pull request
Nov 21, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [Bridge/PhpUnit] fix installation path | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25067 | License | MIT | Doc PR | - Fixes yesterdays's work on the bridge, tricky one... Commits ------- bd4fe8d [Bridge/PhpUnit] fix installation path
greg0ire
reviewed
Nov 30, 2017
| if (file_exists($path.'/vendor/symfony/phpunit-bridge/composer.json')) { | ||
| $path .= '/vendor/symfony/phpunit-bridge'; | ||
| $root = __DIR__; | ||
| while (!file_exists($root.'/composer.json') || file_exists($root.'/bin/simple-phpunit')) { |
There was a problem hiding this comment.
@fbourigault do you know what the second part of the if is about?
There was a problem hiding this comment.
We are going up in directories until we find a composer.json or a bin/simple-phpunit. IMHO this is a special case for Symfony monolithic repository.
There was a problem hiding this comment.
Thanks for answering, I got it straight from the horse's mouth in the meantime but forgot I asked you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes yesterdays's work on the bridge, tricky one...