Use a more specific file for detecting the bridge #25230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
greg0ire
commented
Nov 30, 2017
| Q | A |
|---|---|
| Branch? | 3.4 because this patch cannot apply before |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25228 |
| License | MIT |
| Doc PR | n/a |
When using bin as a Composer bin-dir, this will break because both composer.json and bin/simple-phpunit will exist relatively to the current directory. This change checks for a non-binary file specific to the bridge that will not have this issue. Fixes symfony#25228
nicolas-grekas
approved these changes
Nov 30, 2017
|
Thank you @greg0ire. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 1, 2017
This PR was merged into the 3.4 branch. Discussion ---------- Use a more specific file for detecting the bridge | Q | A | ------------- | --- | Branch? | 3.4 because this patch cannot apply before | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25228 | License | MIT | Doc PR | n/a Commits ------- 355bbd1 Use a more specific file for detecting the bridge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.