Skip to content

Conversation

glye
Copy link
Contributor

@glye glye commented Jan 16, 2018

Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #25792
License MIT
Doc PR

Adds translations for nn (Norwegian Nynorsk) based on no aka. nb (Norwegian Bokmål).
Improves existing translations.

</trans-unit>
<trans-unit id="3">
<source>Authentication request could not be processed due to a system problem.</source>
<target>Autentiseringa vart ikkje prosessert på grunn av ein systemfeil.</target>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above the more layman term Pålogging is used, should it be used here to?

Context:

  • Pålogging is more or less same as Login
  • Authentication in Norwegian (all forms), is less common then in english
    • That said I'm in tech sector surrounded by these words in english all the time, so I'm partial. Maybe the wording should have been simplified also in english, or maybe it's supposed to be technical and thus should also be in Norwegian 🙃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same goes for token/teikn. How technical should it be? I did translate that, but not "nonce". I'll check these against the list Språkrådet made for this purpose.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was checking the same thing and I think that is ok as is (didn't find anything that would be making sense on nonce on some quick looks)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now it's best to replace all of these with innlogging. Slightly more layman, and referenced in the dictionary.

</trans-unit>
<trans-unit id="5">
<source>Cookie has already been used by someone else.</source>
<target>Cookie-en er allereie brukt av ein annan brukar.</target>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would probably involve diverging from no, but should probably be Informasjonskapsel, or not applicable in nn?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's allowed. I'll review, same as above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Kjeks" is also allowed here, actually :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha.. Lets skip the crackers :)

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Jan 16, 2018
</trans-unit>
<trans-unit id="11">
<source>No token could be found.</source>
<target>Fann ingen teikn.</target>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case we are loosing a bit of context here, is this referring to CSRF token?

If so maybe use CSRF-teikn as teikn in nn i far more generic word.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message is used in context of "remember me" tokens.

Copy link
Contributor

@andrerom andrerom Jan 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, does the interface make this clear? As in what kind of token string is being referred to is intuitive here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are authentication tokens. I have used "innloggingsteikn" in another place. Not sure if that is good, but at least it clarifies it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with you @derrabus ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't speak Norwegian, so I cannot decide if a translation is good. 😉

Copy link
Contributor

@andrerom andrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 with resolving the nitpick on token word done

@glye
Copy link
Contributor Author

glye commented Jan 17, 2018

Update: Clarified that token is authentication token.

@fabpot
Copy link
Member

fabpot commented Jan 17, 2018

Is it ready to merge?

@glye
Copy link
Contributor Author

glye commented Jan 18, 2018

@fabpot Yes, ready to go.

@fabpot
Copy link
Member

fabpot commented Jan 18, 2018

Thank you @glye.

@fabpot fabpot merged commit 9b4b7d0 into symfony:2.7 Jan 18, 2018
fabpot added a commit that referenced this pull request Jan 18, 2018
This PR was merged into the 2.7 branch.

Discussion
----------

Norwegian Nynorsk translation

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25792
| License       | MIT
| Doc PR        |

Adds translations for `nn` (Norwegian Nynorsk) based on `no` aka. `nb` (Norwegian Bokmål).
Improves existing translations.

Commits
-------

9b4b7d0 Add nn (Norwegian Nynorsk) translation files, and improve existing file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants