Skip to content

Enableable ArrayNodeDefinition is disabled for empty configuration #25874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

mateuszsip
Copy link
Contributor

Q A
Branch? 2.7+
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #25760, #25862
License MIT

#25789 broke yaml's ~ syntax because here NULL is converted to [] .
It has to be converted because ContainerBuilder:;loadFromExtension expects an array, but I have no clue how can we differentiate these two different states now withou leaking config component implementation details.

8669a21 reproduced issue, and 73ee9a1 presents the simplest way to fix regression.

That's the only idea I got, but as I said, we are leaking implementation details here :(

Any ideas?

@mateuszsip
Copy link
Contributor Author

73ee9a1 presents the simplest way to fix regression.
it doesn't, need to find another way.

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Jan 22, 2018
@xabbuh
Copy link
Member

xabbuh commented Jan 22, 2018

see #25891

@xabbuh xabbuh closed this Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants