[Form] ability to set rounding strategy for MoneyType #26767
Conversation
|
would you mind adding some tests please? |
e63a499 to
f3b1424
Compare
|
@nicolas-grekas You're welcome :) Added tests for the changes, please take a look. |
|
Thank you @syastrebov. |
…(syastrebov) This PR was merged into the 4.1-dev branch. Discussion ---------- [Form] ability to set rounding strategy for MoneyType | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | no | License | MIT | Doc PR | symfony/symfony-docs#9543 Added `rounding_mode` to the `MoneyType` to be possible to change rounding strategy for money values. For now it's just `ROUND_HALF_UP` but it's good to have `ROUND_DOWN` as well. E.g. to transform `15.999` to `15.99` instead of `15.1`. Commits ------- f3b1424 rounding_mode for money type
This PR was merged into the master branch. Discussion ---------- rounding_mode for money type Added docs for symfony/symfony#26767 Commits ------- 819d0a6 rounding_mode for money type
| 'divisor' => 1, | ||
| 'currency' => 'EUR', | ||
| 'compound' => false, | ||
| )); | ||
|
|
||
| $resolver->setAllowedValues('rounding_mode', array( | ||
| NumberToLocalizedStringTransformer::ROUND_FLOOR, |
There was a problem hiding this comment.
Why using NumberToLocalizedStringTransformer and not NumberFormatter here ? Adding a dependency to a transformer without using it doesn't seem right.
There was a problem hiding this comment.
NumberToLocalizedStringTransformer is the parent class of the MoneyToLocalizedStringTransformer which is used by this form type and that is configured through these options.
There was a problem hiding this comment.
Then why not MoneyToLocalizedStringTransformer::ROUND_FLOOR ?
|
@syastrebov how to round-up by 100, sir? round-down by 100? |
Added
rounding_modeto theMoneyTypeto be possible to change rounding strategy for money values. For now it's justROUND_HALF_UPbut it's good to haveROUND_DOWNas well. E.g. to transform15.999to15.99instead of15.1.