rounding_mode for money type #9543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a015ecc to
47954fe
Compare
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Apr 4, 2018
…(syastrebov) This PR was merged into the 4.1-dev branch. Discussion ---------- [Form] ability to set rounding strategy for MoneyType | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | no | License | MIT | Doc PR | symfony/symfony-docs#9543 Added `rounding_mode` to the `MoneyType` to be possible to change rounding strategy for money values. For now it's just `ROUND_HALF_UP` but it's good to have `ROUND_DOWN` as well. E.g. to transform `15.999` to `15.99` instead of `15.1`. Commits ------- f3b1424 rounding_mode for money type
xabbuh
reviewed
Apr 10, 2018
reference/forms/types/money.rst
Outdated
| @@ -16,6 +16,7 @@ how the input and output of the data is handled. | |||
| +-------------+---------------------------------------------------------------------+ | |||
| | Options | - `currency`_ | | |||
| | | - `divisor`_ | | |||
| | | - `rounding_mode`_ | | |||
There was a problem hiding this comment.
should be after grouping IMO to sort the options alphabetically
47954fe to
268e439
Compare
268e439 to
819d0a6
Compare
xabbuh
approved these changes
Apr 11, 2018
|
@syastrebov thanks a lot for contributing these missing docs. It was a great first contribution to Symfony Docs! |
javiereguiluz
added a commit
that referenced
this pull request
Apr 16, 2018
This PR was merged into the master branch. Discussion ---------- rounding_mode for money type Added docs for symfony/symfony#26767 Commits ------- 819d0a6 rounding_mode for money type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added docs for symfony/symfony#26767