Skip to content

[Messenger] Fix default bus name #27199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2018
Merged

[Messenger] Fix default bus name #27199

merged 1 commit into from
May 9, 2018

Conversation

ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented May 8, 2018

Q A
Branch? 4.1
Bug fix? yesish
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27162
License MIT
Doc PR N/A

After #27162, the default bus name configured automatically should use a full service id too, otherwise we currently get a default service id, no namespace identifier, which is the default bus.

Copy link
Contributor

@sroze sroze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. So we keep message_bus, and be consistent with the updated documentation (i.e. to manually use messenger.bus.*)

@sroze sroze added the Messenger label May 8, 2018
@fabpot
Copy link
Member

fabpot commented May 9, 2018

Thank you @ogizanagi.

@fabpot fabpot merged commit fa9b984 into symfony:4.1 May 9, 2018
fabpot added a commit that referenced this pull request May 9, 2018
This PR was merged into the 4.1 branch.

Discussion
----------

[Messenger] Fix default bus name

| Q             | A
| ------------- | ---
| Branch?       | 4.1 <!-- see below -->
| Bug fix?      | yesish
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #27162   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

After #27162, the default bus name configured automatically should use a full service id too, otherwise we currently get a `default` service id, no namespace identifier, which is the default bus.

Commits
-------

fa9b984 [Messenger] Fix default bus name
@ogizanagi ogizanagi deleted the fix/messenger/default_bus_name branch May 9, 2018 06:02
@fabpot fabpot mentioned this pull request May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants