[Workflow] add is deprecated since Symfony 4.1. Use addWorkflow() instead #27209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xkobal
commented
May 9, 2018
| Q | A |
|---|---|
| Branch? | 4.1 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #... |
| License | MIT |
| Doc PR | symfony/symfony-docs#... |
|
this is broken, because the min support version of the workflow component is still 3.4 currently. There is 2 solutions here:
I would go for the first solution. Requiring people to upgrade to workflow 4.1+ when they upgrade FrameworkBundle to 4.1 is fine. |
|
It's done. Tell me if my changes on composer.json are ok. Thanks. |
stof
approved these changes
May 9, 2018
fabpot
approved these changes
May 9, 2018
|
Thank you @xkobal. |
fabpot
added a commit
that referenced
this pull request
May 9, 2018
…kflow() instead (xkobal) This PR was squashed before being merged into the 4.1 branch (closes #27209). Discussion ---------- [Workflow] add is deprecated since Symfony 4.1. Use addWorkflow() instead | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Commits ------- ffa5d1c [Workflow] add is deprecated since Symfony 4.1. Use addWorkflow() instead
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.