[FrameworkBundle] Debug container environment variables #27684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jun 22, 2018
|
screenshot updated and JSON version included. I think the data set is pretty nice, and leaves us figuring out how to display processors/processed value in the text table without cluttering output too much. Still need to extract the actual prefixes though :) |
|
text version conceptually ready :) |
fabpot
reviewed
Oct 10, 2018
There was a problem hiding this comment.
I really like this one and I would like to get it for 4.2. @ro0NL Can you finish it? Any comments @nicolas-grekas
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/MarkdownDescriptor.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/XmlDescriptor.php
Outdated
Show resolved
Hide resolved
not really, do you suggest to throw from any format other then text? |
|
Throwing an exception sounds good to me. |
Merged
|
aiming for
|
|
screenshots updated |
|
i dropped JSON support as well, no real need for a machine format to inspect/debug envs. They are bound to the current environment/runtime anyway. |
chalasr
reviewed
Oct 27, 2018
src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/JsonDescriptor.php
Outdated
Show resolved
Hide resolved
|
@ro0NL Any chance to finish this one for 4.3? :) |
fabpot
added a commit
that referenced
this pull request
Mar 24, 2019
This PR was squashed before being merged into the 4.3-dev branch (closes #28898). Discussion ---------- [Console] Add dumper | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#10502 This PR adds a new `Dumper` helper in the Console component. As there are 2 types of dumps - debug purpose (e.g. `dd()`, `dump()`) - output purpose (see #24208, #27684) For the latter we cannot use the global system (debug) dumper, i.e. `VarDumper::dump()`, we need something tied to the current output and dependency free. Here it is: ```php $io = new SymfonyStyle($input, $output); $dumper = new Dumper($io); $io->writeln($dumper([-0.5, 0, 1])); $io->writeln($dumper(new \stdClass())); $io->writeln($dumper(123)); $io->writeln($dumper('foo')); $io->writeln($dumper(null)); $io->writeln($dumper(true)); ``` With VarDumper comonent:  Without:  > #27684 (comment) var-dumper is not a mandatory dep of fwb, can we do without? Now we can :) Commits ------- fc7465c [Console] Add dumper
|
@ro0NL What needs to be done before merging? |
|
@fabpot ready. Failures unrelated. |
fabpot
approved these changes
Mar 25, 2019
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Mar 25, 2019
…s (ro0NL) This PR was squashed before being merged into the 4.3-dev branch (closes #27684). Discussion ---------- [FrameworkBundle] Debug container environment variables | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> This PR is an attempt to ease debugging environment variables used by the container. Main purpose is to tell which are missing and show detailed usage information.   Commits ------- b813a05 [FrameworkBundle] Debug container environment variables
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to ease debugging environment variables used by the container. Main purpose is to tell which are missing and show detailed usage information.