Redesigned the default error page in production #27699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlopes
approved these changes
Jun 25, 2018
|
Can you add a screenshot (before/after)? |
|
Yes! I've updated the description with the before/after comparison. |
fabpot
approved these changes
Jun 25, 2018
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Jun 25, 2018
…reguiluz) This PR was merged into the 4.2-dev branch. Discussion ---------- Redesigned the default error page in production | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22964 | License | MIT | Doc PR | - This continues the work done in #27071. Before/After comparison:  Commits ------- 1df8b3e Redesigned the default error page in production
fabpot
added a commit
that referenced
this pull request
Jun 26, 2018
This PR was merged into the 3.4 branch. Discussion ---------- Redesign the Debug error page in prod | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22964 | License | MIT | Doc PR | - In `debug` mode, things are unchanged and the page looks like this:  In `non-debug` mode, all Symfony-related things are removed and we use the same minimal design as the default `prod` error pages (see #27699):  Commits ------- 7b9b1b9 Redesign the Debug error page in prod
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the work done in #27071.
Before/After comparison: