Skip to content

Redesign the Debug error page in prod #27722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Conversation

javiereguiluz
Copy link
Member

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #22964
License MIT
Doc PR -

In debug mode, things are unchanged and the page looks like this:

error-debug

In non-debug mode, all Symfony-related things are removed and we use the same minimal design as the default prod error pages (see #27699):

error-no-debug

@fabpot
Copy link
Member

fabpot commented Jun 26, 2018

Thank you @javiereguiluz.

@fabpot fabpot merged commit 7b9b1b9 into symfony:3.4 Jun 26, 2018
fabpot added a commit that referenced this pull request Jun 26, 2018
This PR was merged into the 3.4 branch.

Discussion
----------

Redesign the Debug error page in prod

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22964
| License       | MIT
| Doc PR        | -

In `debug` mode, things are unchanged and the page looks like this:

![error-debug](https://user-images.githubusercontent.com/73419/41900161-5a2dfc3a-792e-11e8-8806-6333cce8cee9.png)

In `non-debug` mode, all Symfony-related things are removed and we use the same minimal design as the default `prod` error pages (see #27699):

![error-no-debug](https://user-images.githubusercontent.com/73419/41900218-798fda6c-792e-11e8-8b8e-22415ab810ac.png)

Commits
-------

7b9b1b9 Redesign the Debug error page in prod
This was referenced Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants