[Form] Remaining changes for bootstrap 4 file fields #27958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Also I changed the previous fake-id from |
ro0NL
reviewed
Jul 16, 2018
| @@ -119,7 +119,7 @@ | |||
| <{{ element|default('div') }} class="custom-file"> | |||
| {%- set type = type|default('file') -%} | |||
| {{- block('form_widget_simple') -}} | |||
| <label for="{{ form.vars.id }}" class="custom-file-label">Choose File</label> | |||
| <label for="{{ form.vars.id }}" class="custom-file-label">{{ attr.placeholder | default("") }}</label> | |||
There was a problem hiding this comment.
attr.placeholder|default('') for consistency
There was a problem hiding this comment.
also it should be translatable i guess 🤔
There was a problem hiding this comment.
I fixed the inconsistency (my tunnel vision was strong there I guess).
I want to answer it here, as this is an important point and I don't want to discuss it in a collapsed code comment. I thought about that as well, but as the default placeholder ( |
|
@apfelbox AFAIK we're already translating placeholders, ... and title attributes for that matter: |
|
WELL… updated. 😅 |
|
im guessing some composer constraint needs a bump for tests to pass :) |
|
The |
ro0NL
approved these changes
Jul 16, 2018
fabpot
approved these changes
Jul 16, 2018
|
Thank you @apfelbox. |
fabpot
added a commit
that referenced
this pull request
Jul 16, 2018
…lbox) This PR was merged into the 4.1 branch. Discussion ---------- [Form] Remaining changes for bootstrap 4 file fields | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | — | License | MIT | Doc PR | — Hi again, This is a follow-up PR for #27919 Apparently I talked about it in the previous PR, but forgot to actually push the change. Sorry about that! 😞 This PR no actually adds this instead of just talking about it:  Sorry again, just forgot to actually update the last PR. Commits ------- 3cd2eef Add placeholder support in bootstrap 4 file fields
nicolas-grekas
pushed a commit
to nicolas-grekas/symfony
that referenced
this pull request
Jul 23, 2018
…s (apfelbox) This PR was merged into the 4.1 branch. Discussion ---------- [Form] Remaining changes for bootstrap 4 file fields | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | — | License | MIT | Doc PR | — Hi again, This is a follow-up PR for symfony#27919 Apparently I talked about it in the previous PR, but forgot to actually push the change. Sorry about that! 😞 This PR no actually adds this instead of just talking about it:  Sorry again, just forgot to actually update the last PR. Commits ------- 3cd2eef Add placeholder support in bootstrap 4 file fields
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Aug 7, 2018
… in bootstrap 4 (MrMitch) This PR was merged into the 4.1 branch. Discussion ---------- [Form] Remove extra .form-group wrapper around file widget in bootstrap 4 | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a This is a follow-up to #27958 and #27919 by @apfelbox . It fixes an extra space between the help text of a FileType widget and the widget itself. The extra space was caused by a `.form-group` wrapper in the `file_widget` block. Commits ------- 01e7fe4 [Form] Remove extra .form-group wrapper around file widget in bootstrap 4
symfony-splitter
pushed a commit
to symfony/twig-bridge
that referenced
this pull request
Aug 7, 2018
…ap 4 This is a follow-up to symfony/symfony#27958 and symfony/symfony#27919. It fixes an extra space between the help text of a FileType widget and the widget itself. The extra space was cause by a .form-group wrapper in the file_widget block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again,
This is a follow-up PR for #27919
Apparently I talked about it in the previous PR, but forgot to actually push the change. Sorry about that! 😞
This PR no actually adds this instead of just talking about it:
Sorry again, just forgot to actually update the last PR.