Skip to content

Remove the Expires header when calling Response::expire() #28083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2018
Merged

Remove the Expires header when calling Response::expire() #28083

merged 1 commit into from
Aug 2, 2018

Conversation

javiereguiluz
Copy link
Member

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #13341
License MIT
Doc PR -

@javiereguiluz javiereguiluz added this to the 2.8 milestone Jul 27, 2018
@javiereguiluz javiereguiluz mentioned this pull request Jul 27, 2018
Closed
@fabpot
Copy link
Member

fabpot commented Aug 2, 2018

Thank you @javiereguiluz.

@fabpot fabpot merged commit ac0cd15 into symfony:2.8 Aug 2, 2018
fabpot added a commit that referenced this pull request Aug 2, 2018
@fabpot
bug #28083 Remove the Expires header when calling Response::expire() …
5d8bf16 
…(javiereguiluz)

This PR was merged into the 2.8 branch.

Discussion
----------

Remove the Expires header when calling Response::expire()

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #13341   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | -

Commits
-------

ac0cd15 Remove the Expires header when calling Response::expire()
This was referenced Aug 27, 2018
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Bug HttpFoundation Status: Reviewed
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.
5 participants
@javiereguiluz @fabpot @nicolas-grekas @OskarStark @carsonbot