Skip to content

[Form] Remove duplicate .form-group in bootstrap 4 file field #28116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Form] Remove duplicate .form-group in bootstrap 4 file field #28116

wants to merge 1 commit into from

Conversation

apfelbox
Copy link
Contributor

@apfelbox apfelbox commented Aug 2, 2018

Q A
Branch? 4.1
Bug fix? yes/no
New feature? /no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27919 (comment)
License MIT
Doc PR

When reworking the bootstrap 4 file field (in #27919) I added the .form-group div twice.
We can safely remove it in the file_widget, as the widget is already wrapped in a .form-group in the form_row

Thanks to @MrMitch for the report 👍

@apfelbox
Copy link
Contributor Author

apfelbox commented Aug 2, 2018

Too slow, duplicated by #28115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants