Skip to content

[Cache] enable Memcached::OPT_TCP_NODELAY to fix perf of misses #28249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2018

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28248
License MIT
Doc PR -

As described in php-memcached-dev/php-memcached#24 and because we enable the binary protocol by default.

Copy link
Contributor

@andrerom andrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is essentially bug I would say this should go to 3.4, but that is just me :)

@nicolas-grekas nicolas-grekas changed the base branch from master to 3.4 August 23, 2018 15:50
@nicolas-grekas nicolas-grekas merged commit 8b59d17 into symfony:3.4 Aug 24, 2018
nicolas-grekas added a commit that referenced this pull request Aug 24, 2018
…isses (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[Cache] enable Memcached::OPT_TCP_NODELAY to fix perf of misses

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28248
| License       | MIT
| Doc PR        | -

As described in php-memcached-dev/php-memcached#24 and because we enable the binary protocol by default.

Commits
-------

8b59d17 [Cache] enable Memcached::OPT_TCP_NODELAY to fix perf of misses
@nicolas-grekas nicolas-grekas deleted the cache-tcp-no-delay branch August 24, 2018 13:46
This was referenced Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants